metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] justinleet commented on a change in pull request #1299: METRON-1929: Build GET_ASN Stellar function
Date Wed, 09 Jan 2019 18:05:20 GMT
justinleet commented on a change in pull request #1299: METRON-1929: Build GET_ASN Stellar
function
URL: https://github.com/apache/metron/pull/1299#discussion_r246484062
 
 

 ##########
 File path: metron-platform/metron-data-management/README.md
 ##########
 @@ -364,7 +364,7 @@ The parameters for the utility are as follows:
 | Short Code | Long Code           | Is Required? | Description                         
                                                            |
 |------------|---------------------|--------------|--------------------------------------------------------------------------------------------------|
 | -h         |                     | No           | Generate the help screen/set of options
                                                         |
-| -g         | --geo_url           | No           | GeoIP URL - defaults to http://geolite.maxmind.com/download/geoip/database/GeoLite2-City.mmdb.gz
|
+| -g         | --geo_url           | No           | GeoIP URL - defaults to http://geolite.maxmind.com/download/geoip/database/GeoLite2-City.tar.gz
|
 
 Review comment:
   Added in the `-ra` option as well as `-re` which apparently got added at some point.
   
   ASN is one of the GeoLite2 databases (the other one we have available is actually the City
database), so it seems reasonable to keep it together.
   
   Should I rename `AsnDatabase` to `GeoLiteAsnDatabase` to make this more clear (and match
`GeoLiteCityDatabase`)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message