metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ottobackwards commented on a change in pull request #1315: METRON-1956 add missing tests and some of the many shellcheck fixes
Date Tue, 15 Jan 2019 15:56:13 GMT
ottobackwards commented on a change in pull request #1315: METRON-1956 add missing tests and
some of the many shellcheck fixes
URL: https://github.com/apache/metron/pull/1315#discussion_r247950691
 
 

 ##########
 File path: dev-utilities/committer-utils/metron-committer-common
 ##########
 @@ -223,13 +223,13 @@ function setup_code {
       # if the repo already exists, allow the user to provide the name of the Github remote
       # this is needed to checkout the code for the PR
       read -p "  name of github remote [$GITHUB_REMOTE]: " INPUT
-      [ -n "$INPUT" ] && GITHUB_REMOTE=${INPUT}
+      [[ -n "$INPUT" ]] && GITHUB_REMOTE=${INPUT}
 
     fi
 
     PR_BRANCH_REF="pull/$PR/head:pr-$PR"
     PR_BRANCH="pr-$PR"
-    cd ${WORK} || exit "failed to move to ${WORK}"
+    cd ${WORK} &> /dev/null || echo "failed to change directory to ${WORK}" &&
exit 1
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message