metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [metron] simonellistonball commented on issue #1408: METRON-2118: Added a LEEF parser
Date Fri, 17 May 2019 19:20:40 GMT
simonellistonball commented on issue #1408: METRON-2118: Added a LEEF parser
URL: https://github.com/apache/metron/pull/1408#issuecomment-493569746
 
 
   > Agree with @ottobackwards. I just had to mess about in the integration tests for parsers,
so here are some links to help that process:
   > 
   > * https://github.com/apache/metron/tree/master/metron-platform/metron-parsing/metron-parsers-common/src/test/java/org/apache/metron/parsers/integration
   > * https://github.com/apache/metron/tree/master/metron-platform/metron-integration-test/src/main/sample/data
   
   Is it really a good idea to keep integration tests for the metron-parsers package in the
metron-parsers-common package? Seems like we're mixing concerns there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message