metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [metron] mmiklavc commented on issue #1408: METRON-2118: Added a LEEF parser
Date Fri, 17 May 2019 20:52:53 GMT
mmiklavc commented on issue #1408: METRON-2118: Added a LEEF parser
URL: https://github.com/apache/metron/pull/1408#issuecomment-493596017
 
 
   > > Agree with @ottobackwards. I just had to mess about in the integration tests
for parsers, so here are some links to help that process:
   > > 
   > > * https://github.com/apache/metron/tree/master/metron-platform/metron-parsing/metron-parsers-common/src/test/java/org/apache/metron/parsers/integration
   > > * https://github.com/apache/metron/tree/master/metron-platform/metron-integration-test/src/main/sample/data
   > 
   > Is it really a good idea to keep integration tests for the metron-parsers package
in the metron-parsers-common package? Seems like we're mixing concerns there.
   
   I tend to agree, though a handful of them are considered "common."
   
   - "jsonMap",
   - "jsonMapQuery",
   - "jsonMapWrappedQuery",
   - "syslog3164",
   - "syslog5424"
   
   This should probably be split up a bit, but I don't think it needs to happen in this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message