metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [metron] justinleet opened a new pull request #1554: METRON-2307: Migrate to JUnit5
Date Mon, 04 Nov 2019 16:29:41 GMT
justinleet opened a new pull request #1554: METRON-2307: Migrate to JUnit5
URL: https://github.com/apache/metron/pull/1554
 
 
   ## Contributor Comments
   Moves to JUnit 5. This came out of my forever ago desire to look into JUnit5 extensions
to share test infra (Kafka, ZK, etc.) across our test classes, rather than spin up for each
class.
   
   - Migrates everything to JUnit5 annotations.
   - Migrates everything to JUnit5 assertions. This includes making everything `assertThrows`
   - The only `@Rule`s left are for temporary directories. This feature is experimental in
JUnit5 (although I do use it once for a `@ClassRule` one.  We could potentially migrate over,
it's not like it'd be a huge deal to upgrade to whatever they choose in the future.
   - PowerMock is gone. Doesn't work in JUnit 5. Various methods are added to source to be
able to mock out / spy on / whatever to get it to work. Tried to be pretty minimal about this
change, since it hits outside of tests.
   - I believe a single test got deleted: One for a two line method in `MetronRestApplication`,
iirc. Didn't seem super helpful to test that it ran the `SpringApplication`.
    
   Build works (potentially barring the last couple cleanup commits which are going through
my personal Travis), but I still need to spin it up on dev.
   
   I'm not super thrilled about this being a large PR, but it was an enormous pain that kept
finding things backwards in modules I thought I'd already cleared. It could probably be split
out, but I'll be honest: If I see that request, I'll probably ignore it for awhile.
   
   ## Pull Request Checklist
   
   Thank you for submitting a contribution to Apache Metron.  
   Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.  
   Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.  
   
   
   In order to streamline the review of the contribution we ask you follow these guidelines
and ask you to double check the following:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
   - [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying
to resolve? Pay particular attention to the hyphen "-" character.
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically
master)?
   
   
   ### For code changes:
   - [ ] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
   - [ ] Have you included steps or a guide to how the change may be verified and tested manually?
   - [ ] Have you ensured that the full suite of tests and checks have been executed in the
root metron folder via:
     ```
     mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh

     ```
   
   - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] Have you verified the basic functionality of the build by building and running locally
with Vagrant full-dev environment or the equivalent?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered
by building and verifying the site-book? If not then run the following commands and the verify
changes via `site-book/target/site/index.html`:
   
     ```
     cd site-book
     mvn site
     ```
   
   - [ ] Have you ensured that any documentation diagrams have been updated, along with their
source files, using [draw.io](https://www.draw.io/)? See [Metron Development Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines)
for instructions.
   
   #### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit
an update to your PR as soon as possible.
   It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal
repository such that your branches are built there before submitting a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message