metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [metron] mmiklavc commented on issue #1554: METRON-2307: Migrate to JUnit5
Date Tue, 05 Nov 2019 16:47:58 GMT
mmiklavc commented on issue #1554: METRON-2307: Migrate to JUnit5
URL: https://github.com/apache/metron/pull/1554#issuecomment-549907637
 
 
   @justinleet wowowow, this is an awesome contribution. It's going to take me a bit of time
to work through this.
   
   > PowerMock is gone. Doesn't work in JUnit 5. Various methods are added to source to
be able to mock out / spy on / whatever to get it to work. Tried to be pretty minimal about
this change, since it hits outside of tests.
   
   Any reason we specifically still need/want PowerMock? That was purely for special static
mocking purposes, right? Personally, I'm happy to see this cleaned this up and have our testing
infrastructure as super simple JUnit + Mockito.
   
   > I believe a single test got deleted: One for a two line method in MetronRestApplication,
iirc. Didn't seem super helpful to test that it ran the SpringApplication.
   
   Can you link that here? Sounds like a reasonable drop, per your description.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message