metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [metron] justinleet commented on issue #1554: METRON-2307: Migrate to JUnit5
Date Tue, 05 Nov 2019 17:46:54 GMT
justinleet commented on issue #1554: METRON-2307: Migrate to JUnit5
URL: https://github.com/apache/metron/pull/1554#issuecomment-549935562
 
 
   > Any reason we specifically still need/want PowerMock? That was purely for special
static mocking purposes, right? Personally, I'm happy to see this cleaned this up and have
our testing infrastructure as super simple JUnit + Mockito.
   
   To the best of my knowledge, no, we don't. Nothing we were doing was super out there. What
I generally did was expose a bit more state; it suggests refactoring might make that cleaner,
but it's way out of scope and honestly probably low priority anyway.
   
   I actually made sure to drop it from all the poms. If there's any PowerMock left, it's
an oversight.
   
   > > I believe a single test got deleted: One for a two line method in MetronRestApplication,
iirc. Didn't seem super helpful to test that it ran the SpringApplication.
   > 
   > Can you link that here? Sounds like a reasonable drop, per your description.
   
   https://github.com/apache/metron/blob/2ee6cc7e0b448d8d27f56f873e2c15a603c53917/metron-interface/metron-rest/src/test/java/org/apache/metron/rest/MetronRestApplicationTest.java

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message