metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [metron] mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore
Date Tue, 05 Nov 2019 18:30:46 GMT
mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore
URL: https://github.com/apache/metron/pull/1546#issuecomment-549956618
 
 
   >  I don't think I would call the existing bash scripts style and practice.
   
   Wouldn't call them what?
   
   > I think it is a good practice, and makes it really clear for everyone contributing
to script code what is required.
   
   I think it's a good practice to have standards also - we typically discuss them on the
dev list. I just haven't heard of or used that tool before, so I'm unclear what the alternatives
are.
   
   > That being said, it is _not_ the project standard, so I can't make you do it.
   
   I ran it and shared the remaining results in my comment - all I see at the moment are warnings
regarding double quotes. Is there anything in that list (or all of it?) you think we should
do? It's not a hard change to make, but I do think it makes the script messier for something
that we have never run into afaik. I don't have a strong opinion on it either way.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message