metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests
Date Wed, 29 Apr 2020 02:49:00 GMT

JonZeolla commented on a change in pull request #42:
URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417038403



##########
File path: docker/scripts/docker_run_create_topic_in_kafka.sh
##########
@@ -80,7 +80,10 @@ echo "Running docker_run_create_topic_in_kafka with "
 echo "NETWORK_NAME = $NETWORK_NAME"
 echo "==================================================="
 
-docker run --rm --network "${NETWORK_NAME}" ches/kafka \
+# TODO: Fix this
+sleep 2s

Review comment:
       @ottobackwards Open to suggestions - would prefer not need to go back to using `wait-for-it.sh`
but that seems to be a rather [standard approach](https://docs.docker.com/compose/startup-order/)
to solving this problem.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message