metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests
Date Wed, 29 Apr 2020 03:21:46 GMT

JonZeolla commented on a change in pull request #42:
URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417045900



##########
File path: docker/README.md
##########
@@ -209,33 +140,21 @@ testing scripts to be added to a pull request, and subsequently to a
test suite.
   ```bash
   --log-directory                [REQUIRED] The directory with the logs
   ```
-- `stop_container.sh`: Stops and removes a Docker container with a given name
-  ###### Parameters
-  ```bash
-  --container-name               [REQUIRED] The Docker container name
-  ```
 
 #### The example end to end test script
 
 `run_end_to_end.sh` is provided as an example of a testing script.  Specific or extended
scripts can be created similar to this script to use the containers.
 This script does the following:
 

Review comment:
       Yes because it auto numbers in the rendered version




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message