metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests
Date Wed, 29 Apr 2020 03:42:30 GMT

JonZeolla commented on a change in pull request #42:
URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417050279



##########
File path: docker/containers/kafka/Dockerfile
##########
@@ -16,20 +14,4 @@
 #  See the License for the specific language governing permissions and
 #  limitations under the License.
 #

Review comment:
       Correct, not required.  I did it both ways but chose to keep this because I was looking
to follow on with moving commands into the containers instead of docker exec/run scripts,
maybe making a new entry point.
   
   I actually did this work twice because the first time there was too much change and it
with have been difficult to review.
   
   I can remove for now and add later if you prefer?  At the end of the day, it's just the
same layers tagged differently




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message