metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests
Date Wed, 29 Apr 2020 03:46:02 GMT

JonZeolla commented on a change in pull request #42:
URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417050898



##########
File path: docker/scripts/docker_run_create_topic_in_kafka.sh
##########
@@ -80,7 +80,10 @@ echo "Running docker_run_create_topic_in_kafka with "
 echo "NETWORK_NAME = $NETWORK_NAME"
 echo "==================================================="
 
-docker run --rm --network "${NETWORK_NAME}" ches/kafka \
+# TODO: Fix this
+sleep 2s

Review comment:
       I may, let me think on it.  Was hoping to remove the MIT license and all the overhead
but compose isn't as capable as k8s readiness




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message