metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [metron-bro-plugin-kafka] JonZeolla opened a new pull request #43: METRON-2349: [BRO-PLUGIN-KAFKA] Fix hard coded topic_name in e2e tests
Date Wed, 29 Apr 2020 18:30:04 GMT

JonZeolla opened a new pull request #43:
URL: https://github.com/apache/metron-bro-plugin-kafka/pull/43


   ## Contributor Comments
   Fixes e2e tests when a custom kafka topic is specified.  Previously everything would have
completed without error, but the bro container would have sent to a hard coded `bro` topic.
 This is based off of #42 for the time being, until that is merged and I will rebase on `master`.
   
   ### Testing
   Run `./run_end_to_end.sh --kafka-topic=testing` and see that it works
   
   
   ## Pull Request Checklist
   Thank you for submitting a contribution to Apache Metron's Bro kafka writer plugin.
   
   In order to streamline the review of the contribution we ask you follow these guidelines
and ask you to double check the following:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
   - [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying
to resolve? Pay particular attention to the hyphen "-" character.
   - [X] Has your PR been rebased against the latest commit within the target branch (typically
master)?
   
   ### For code changes:
   - [X] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
   - [ ] Have you included steps or a guide to how the change may be verified and tested manually?
   - [X] Have you ensured that the full suite of tests and checks have been executed via:
     ```
     bro-pkg test $GITHUB_USERNAME/metron-bro-plugin-kafka --version $BRANCH
     ```
   - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] Have you verified the basic functionality of the build by building and running locally
with Apache Metron's [Vagrant full-dev environment](https://github.com/apache/metron/tree/master/metron-deployment/development/centos6)
or the equivalent?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message