mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Duffy (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIRMINA-162) datagram session management fails
Date Thu, 14 Sep 2006 09:23:25 GMT
    [ http://issues.apache.org/jira/browse/DIRMINA-162?page=comments#action_12434623 ] 
            
Greg Duffy commented on DIRMINA-162:
------------------------------------

I always forget something after I hit 'submit'.

In ExpiringSessionRecycler, I liked your idea of using the List as the key instead of the
concatenated String representation. I must have been on crack when I did it that way :) 

I also saw your comments about IdentityHashMap. I don't think returned SocketAddresses from
the channels are guaranteed to be reference equal?

I think ConcurrentHashMap (used in my v4 patch) is a good middle ground because it tries to
avoid any synchronization (as much as possible) for simple reads (which, if the user wants
recycling, will probably be the vast majority of calls) and only synchronizes when a change
to the map is in progress.

Just my $0.02. (I have a lot of 'em, eh?)

Thanks for keeping up with this Trustin, and I look forward to your feedback.

> datagram session management fails
> ---------------------------------
>
>                 Key: DIRMINA-162
>                 URL: http://issues.apache.org/jira/browse/DIRMINA-162
>             Project: Directory MINA
>          Issue Type: Bug
>    Affects Versions: 0.9
>            Reporter: Rainer Bieniek
>         Assigned To: Trustin Lee
>            Priority: Minor
>             Fix For: 1.0
>
>         Attachments: mina-datagram-session-management-v2.diff, mina-datagram-session-management-v3.diff,
mina-datagram-session-management-v4.diff, mina-datagram-session-management.diff
>
>
> As of mina 0.9.0 the session management does not work in various ways:
> - a new session is created per received package. The worker thread does not cache created
session but only assign the select key to the session and drops it after processing the package.
It would be better to attach the session to the RegistrationRequest and check it while processing
the received package.
> - the provided IoFilterChainBuilder does get applied to the created datagram session.
It is cached in the RegistrationRequest but not used on the session
> - The sessionClose lifecycle event is not applied on the session either. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message