From dev-return-5918-apmail-mina-dev-archive=mina.apache.org@mina.apache.org Tue May 29 06:55:09 2007 Return-Path: Delivered-To: apmail-mina-dev-archive@www.apache.org Received: (qmail 98218 invoked from network); 29 May 2007 06:55:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 29 May 2007 06:55:08 -0000 Received: (qmail 51195 invoked by uid 500); 29 May 2007 06:55:11 -0000 Delivered-To: apmail-mina-dev-archive@mina.apache.org Received: (qmail 51162 invoked by uid 500); 29 May 2007 06:55:10 -0000 Mailing-List: contact dev-help@mina.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mina.apache.org Delivered-To: mailing list dev@mina.apache.org Received: (qmail 51153 invoked by uid 99); 29 May 2007 06:55:10 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 May 2007 23:55:10 -0700 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of mbosteels.dns@gmail.com designates 64.233.166.179 as permitted sender) Received: from [64.233.166.179] (HELO py-out-1112.google.com) (64.233.166.179) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 May 2007 23:55:04 -0700 Received: by py-out-1112.google.com with SMTP id a25so3237217pyi for ; Mon, 28 May 2007 23:54:43 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=ZMXoked/tFp96SOHVyGhV5rAOI4Mbo5iFODcWBEDiGjubVrH9MufEJrdXXkeK+Ne4nvmw3vpph/pUjZsdIzGmLgWVivYjDhszgiAIDdysuv2IiwT0oyzhlk9Edln5kqWBJwAQ2Vb6+ZFdMujLMws+30Jyedgrz757LwwSy5MR+w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=H+g7qszXm8izT/2DcF+NKbSaEPwegnCDDM9LJkvXLGYazVrdCsrB7yYJbyCuhDBMZ1SN5JJNXpYJu7vzyfUKJeEEk+eGerJe3VgFm4ZOLlvsUUGdKTJqd/8mVzY9nTVtRIU2wr9jlw1KsmK3I3/qKCkMQt0YWqbCAacdWRPJPMk= Received: by 10.35.90.1 with SMTP id s1mr6467187pyl.1180421683394; Mon, 28 May 2007 23:54:43 -0700 (PDT) Received: by 10.35.122.2 with HTTP; Mon, 28 May 2007 23:54:43 -0700 (PDT) Message-ID: <5e87acee0705282354o13ae6f72p678106f9339a5d26@mail.gmail.com> Date: Tue, 29 May 2007 08:54:43 +0200 From: "Maarten Bosteels" To: dev@mina.apache.org Subject: Re: tutorial on protocol codec In-Reply-To: <768dcb2e0705281852i403e4411nfd44d85eb18a44c9@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_100809_8593493.1180421683346" References: <5e87acee0705271531r5107485em353d0c7947597208@mail.gmail.com> <768dcb2e0705281852i403e4411nfd44d85eb18a44c9@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_100809_8593493.1180421683346 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi Trustin, On 5/29/07, Trustin Lee wrote: > > Hi Maarten, > > On 5/28/07, Maarten Bosteels wrote: > > Hello all, > > > > I created a tutorial on creating a custom ProtocolCodecFilter. > > Please have a look at it and let me know what you think: > > > > > http://cwiki.apache.org/confluence/display/MINA/Tutorial+on+ProtocolCodecFilter > > What a great piece of work! Thank you for your contribution! It > explains why protocol codec is needed and how it works very clearly. Thanks ! I don't see any changes needed in the content, but I'd like to point > out a few cosmetic issues: > > * Prefer wiki markup to rich text editor, which generates many  s. I started out with rich text editor but quickly switched to wiki markup, it's definitely easier. * Use {{...}} expression when referencing a class name (e.g. > {{ProtocolCodecFilter}}). Will remember that for the next tutorial :-) * Use our standard coding style. I thought I did, but apparently I should have read the coding style document. I spent some time putting all those opening curly braces on a new line, because I thought that's how mina code was written :-) Maarten I made a change in the latest revision of the tutorial. > > Cheers, > Trustin > -- > what we call human nature is actually human habit > -- > http://gleamynode.net/ > -- > PGP Key ID: 0x0255ECA6 > ------=_Part_100809_8593493.1180421683346--