mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geoff Cadien" <gcad...@gmail.com>
Subject Bug in DefaultFileRegion
Date Mon, 06 Aug 2007 23:47:26 GMT
I've run into a bug in DefaultFileRegion.  In the method

public void setPosition(long value) {
        if (value < position) {
            throw new IllegalArgumentException("New position value may not
be less than old position value");
        }
        count += value - position;
        position = value;
}

I believe it should be

count -= value - position;

instead.

Also,  SocketIoProcessor#clearWriteRequestQueue the WriteRequest message is
cast to a ByteBuffer, which will fail if the message is a DefaultFileRegion.

I would be happy to enter the two bugs in Jira if thats the correct
procedure.

-geoff

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message