mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Trustin Lee (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIRMINA-490) Add a getSlice(int) method to IoBuffer
Date Fri, 07 Dec 2007 15:39:43 GMT

    [ https://issues.apache.org/jira/browse/DIRMINA-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549445
] 

Trustin Lee commented on DIRMINA-490:
-------------------------------------

It was to make the sliced buffer less error-prone.  Calling duplicate allows a user to move
the position of the duplicated buffer before where it was originally sliced, which is error-prone
in some cases because a user can easily assume that the offset of the first byte is 0.  Using
slice(), you can ensure the offset of the first byte is always 0, which makes the sliced buffer
look more like a separate buffer so a user don't make a mistake.

> Add a getSlice(int) method to IoBuffer
> --------------------------------------
>
>                 Key: DIRMINA-490
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-490
>             Project: MINA
>          Issue Type: New Feature
>          Components: Core
>            Reporter: David M. Lloyd
>            Assignee: Trustin Lee
>            Priority: Minor
>             Fix For: 2.0.0-M1
>
>         Attachments: getSlice.patch
>
>
> Add a method to IoBuffer that lets you read a given number of bytes, returning those
bytes as a slice IoBuffer.
> Enclosed is a simple patch to do this.  This method can be implemented completely in
terms of other IoBuffer methods; therefore it can go on the IoBuffer base class without affecting
other subclasses.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message