mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "이희승 (Trustin Lee) <trus...@gmail.com>
Subject Re: Make LoggingFilter.log() protected
Date Fri, 04 Apr 2008 11:04:11 GMT
Hi Niklas,

Are you using a String as a message type?  Otherwise you could override
toString() so you can mask the password.  I'd suggest you to create a
message class for each message type as defined in FTP.

However, it will take a lot of effort, and therefore I think making
LoggingFilter.log() protected makes sense.  Let me create an issue and
resolve it right now.

Niklas Gustavsson wrote:
> Hi
> I would like to create a custom logging filter for use in FtpServer,
> the reason is to mask out the password sent in the PASS command from
> logs. Here's the RFE:
> https://issues.apache.org/jira/browse/FTPSERVER-120
> To make this reasonably straight-forward without forking the current
> LoggingFIlter, I'm wondering if you would be okay with changing the
> LoggingFilter.log method from private to protected?
> /niklas

Trustin Lee - Principal Software Engineer, JBoss, Red Hat
what we call human nature is actually human habit

View raw message