mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julien Vermillard <jvermill...@archean.fr>
Subject Re: New branch for clearing features
Date Thu, 06 Nov 2008 18:26:50 GMT
On Thu, 6 Nov 2008 11:03:30 +0100
Julien Vermillard <jvermillard@archean.fr> wrote:

> Hi,
> 
> I created a branch in my sandbox for experimenting some core code
> cleaning.
> 
> Here : 
> http://svn.apache.org/repos/asf/mina/sandbox/jvermillard/mina-cleaning/
> 
> Things done : 
>  - killed IoService level Idle (is it usefull when you already got
>    IoSession idle stats ?)
>  - cleared IdleStatusCheker, now only used for transport who can't
>    trigger idle alone (vmpipe & serial)
> 
> Things I would like to do :
>  - renaming & cleaning setTraffic mask in more understandable fashion
>    as proposed in another mail
>  - clearing IoFilter of references to traffic mask events
>  - trying to make throughput statistics less intrusive and optional,
>    because the impact on performance of such code is probably
>    significant.
> 
> Of course if I'm killing something important here I hope you will
> correct me :)
> 
> Julien

I cleared TrafficMask, now it's replaced by suspendRead resumeRead
suspendWrite resumeWrite in IoSession, it's no more tied with filters,
it removed some complexity/LoC.

Could I have some feedback on my branch before thinking of merging ?

Julien

Mime
View raw message