mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edouard De Oliveira (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIRMINA-539) NioDatagramConnector doesn't takes the TrafficClass value set to his DatagramSessionConfig
Date Wed, 19 Nov 2008 00:09:44 GMT

    [ https://issues.apache.org/jira/browse/DIRMINA-539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648825#action_12648825
] 

Edouard De Oliveira commented on DIRMINA-539:
---------------------------------------------

indeed, the example was just intended to highlight the unnecesseray redundant tests happening
with the use of a isSetTrafficClassAvailable(...) method.

http://java.sun.com/j2se/1.4.2/docs/api/java/net/Socket.html#getTrafficClass()
also states that "the underlying network implementation may ignore the traffic class or type-of-service
set using #setTrafficClass()" 
If any error throws an exception i just wonder why the hell this code got so complicated ?

ps : tried to search through mina jira db but found nothing proving that it could fail silently

> NioDatagramConnector doesn't takes the TrafficClass value set to his DatagramSessionConfig

> -------------------------------------------------------------------------------------------
>
>                 Key: DIRMINA-539
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-539
>             Project: MINA
>          Issue Type: Bug
>    Affects Versions: 2.0.0-M1
>         Environment: WinXP, RHEL5 (probably not important)
>            Reporter: martin krivosik
>            Assignee: Emmanuel Lecharny
>             Fix For: 2.0.0-M4
>
>   Original Estimate: 0.33h
>  Remaining Estimate: 0.33h
>
> client sending datagrams without taking care to the trafficClas set in the config, so
the ToS byte is not set in the packet sent from client.
> client code:
>   NioDatagramAcceptor acceptor = new NioDatagramAcceptor();
>   DatagramSessionConfig dcfg = ((NioDatagramAcceptor)acceptor).getSessionConfig();
>   dcfg.setTrafficClass(tosByte);
>   InetSocketAddress bindAddrPort  = new InetSocketAddress(originatingIP, port);
>   acceptor.bind(bindAddrPort);
> -> connecting to another computer with NioDatagramConnector.
> for me it looks like in the newHandle method of NioDatagramConnector is not cared about
TrafficClass (like it is done in NioDatagramAcceptor.open())
> The server part with the accceptor is OK and the correct ToS byte is set in the packet.
> (the same problem may be in the socket, i have to check it)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message