mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sai Pullabhotla <sai.pullabho...@jmethods.com>
Subject Re: [jira] Commented: (FTPSERVER-306) some clients won't transform NEW LINE characters to \r\n when sending in ASCII mode so after sending a file the new lines will be gone.
Date Tue, 26 May 2009 10:38:29 GMT
>> when FtpServer receives a file in ASCII mode our current code replaces \r
for \r\n and ignores \n, but since it seems FileZilla
>> doesn't transform new lines to \r\n  we will never find a \r and the new
line characters will be silently ignored.

Hmm... shouldn't it be just doing the following:

1. Replace \r\n with System.getProperty("line.separator");
2. Write everything else as is.

Sai Pullabhotla
www.jMethods.com



On Tue, May 26, 2009 at 2:34 AM, David Latorre (JIRA) <jira@apache.org>wrote:

>
>    [
> https://issues.apache.org/jira/browse/FTPSERVER-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712889#action_12712889]
>
> David Latorre commented on FTPSERVER-306:
> -----------------------------------------
>
> Sending a file  with \n separated lines  in ASCII mode with FileZilla for
> windows will result in a file with no new lines:
>
>  when FtpServer receives a file in ASCII mode our current code replaces \r
> for \r\n and ignores \n, but since it seems FileZilla doesn't transform new
> lines to \r\n  we will never find a \r and the new line characters will be
> silently ignored.
>
> This is a bug in Filezilla (Might be because im sending "Unix" files from
> windows)   but I doubt every other client is performing this transformation.
> So, when we find a \n we should check if last character was \r and otherwise
> insert the new line sequence.
>
>
>
>
>
>
> > some clients won't  transform NEW LINE characters to \r\n when sending in
> ASCII mode so after sending a file the new lines will be gone.
> >
> -----------------------------------------------------------------------------------------------------------------------------------------
> >
> >                 Key: FTPSERVER-306
> >                 URL: https://issues.apache.org/jira/browse/FTPSERVER-306
> >             Project: FtpServer
> >          Issue Type: Improvement
> >            Reporter: David Latorre
> >
>
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message