mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bernd Fondermann <bf_...@brainlounge.de>
Subject Re: [vysper] Pubsub code organization
Date Sat, 16 May 2009 21:07:39 GMT
Michael Jakl wrote:
> Hi!
> On Sat, May 16, 2009 at 22:52, Bernd Fondermann <bf_jak@brainlounge.de> wrote:
>> For the pubsub module, I'd propose to
>> + move the 'general' and 'owner' package to 'handler', or,
>> alternatively, move the handler classes they contain to two new
>> 'handler' sub-packages respectively.
> +1, I wasn't happy with "general" anyways. What about .handler for the
> current "general" package and .handler.owner for the #owner namespace?

I can do it, if this proves to be too cumbersome to do in a patch.

>> + rename test case classes to *TestCase or *Test so they are clearly
>> identifyable as such by their name. If you use a view where all classes
>> from one package are shown together even if they are on different dirs,
>> this would be a big help.
> +1, the ant task will also profit from the "right" naming.

Great, thanks.


View raw message