mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dennis Keller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FTPSERVER-287) NLST: Implementation only supports listing files in working directory [patch provided]
Date Thu, 04 Jun 2009 20:13:07 GMT

    [ https://issues.apache.org/jira/browse/FTPSERVER-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716384#action_12716384
] 

Dennis Keller commented on FTPSERVER-287:
-----------------------------------------

Interesting discussion. Thanks to all for the evaluation. It seems that there is much disparity
amongst the various FTP server implementations and that the logic in the Apache FTP server
is as correct as the other server's implementations :) I suppose this is what happens when
specifications are vague!

Your suggestions not to rely on the output of NLIST are good and we will change our code so
that it does not use the output of NLST as input to other requests. 

> NLST: Implementation only supports listing files in working directory [patch provided]
> --------------------------------------------------------------------------------------
>
>                 Key: FTPSERVER-287
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-287
>             Project: FtpServer
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1
>         Environment: Fedora 10-64bit and RH 5.2-64bit, Java 1.6.0_12-64 
>            Reporter: Dennis Keller
>             Fix For: 1.0.2, 1.1
>
>         Attachments: nlst.patch
>
>
> The NLST formatter, as implemented on trunk is insufficient to handle any request other
than a file within in the current working directory. Some examples:
> ftp> passive
> Passive mode on.
> ftp> nlist /directory/file.txt
> 227 Entering Passive Mode (127,0,0,1,179,241)
> 150 File status okay; about to open data connection.
> file.txt
> 226 Closing data connection.
> Other FTP servers return the following:
> ftp> passive
> Passive mode on.
> ftp> nlist /directory/file.txt
> 227 Entering Passive Mode (127,0,0,1,179,241)
> 150 File status okay; about to open data connection.
> /directory/file.txt
> 226 Closing data connection.
> Upon investigating, I found that the formatter will not handle absolute file requests,
parent directory request or non-absolute child directory requests. It does not error, it just
doesn't give useful output.
> I've modified the code to handle the cases that I could come up with, but there may be
other situations that need to be covered. I'm not an expert on the FTP specification (but
what I could find was not impressive), so there many be additional cases that need to be covered.
> Please consider the attached patch, with accompanying test cases

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message