mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Fondermann (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (VYSPER-63) Unify error handling for pubsub
Date Mon, 22 Jun 2009 20:47:07 GMT

    [ https://issues.apache.org/jira/browse/VYSPER-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722810#action_12722810
] 

Bernd Fondermann edited comment on VYSPER-63 at 6/22/09 1:46 PM:
-----------------------------------------------------------------

I'd suggest to simply replace 
    return errorStanzaGenerator.generateNoSuchSubscriberErrorStanza(sender, receiver, iqStanzaID);
with
   return ServerErrorResponses.getInstance().getStanzaError(StanzaErrorCondition.UNEXPECTED_REQUEST,
stanza, StanzaErrorType.CANCEL, null, null, null);
and so on.

note that pusub errors *are* stanza errors. they are bound to adhere to
http://tools.ietf.org/html/draft-saintandre-rfc3920bis-09#section-9.3

if you don't want to add the whole IQ, but only the pubsub subelement from the original request,
then we'll find a way to do so.

where doesn't this fit?



      was (Author: brainlounge):
    I'd suggest to simply replace 
    return errorStanzaGenerator.generateNoSuchSubscriberErrorStanza(sender, receiver, iqStanzaID);
with
   return ServerErrorResponses.getInstance().getStanzaError(StanzaErrorCondition.ITEM_NOT_FOUND,
stanza, StanzaErrorType.CANCEL, null, null, null);
and so on.

note that pusub errors *are* stanza errors. they are bound to adhere to
http://tools.ietf.org/html/draft-saintandre-rfc3920bis-09#section-9.3

if you don't want to add the whole IQ, but only the pubsub subelement from the original request,
then we'll find a way to do so.

where doesn't this fit?


  
> Unify error handling for pubsub
> -------------------------------
>
>                 Key: VYSPER-63
>                 URL: https://issues.apache.org/jira/browse/VYSPER-63
>             Project: VYSPER
>          Issue Type: Sub-task
>          Components: XEP0060 PubSub
>            Reporter: Michael Jakl
>            Assignee: Michael Jakl
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message