mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Latorre (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FTPSERVER-287) NLST: Implementation only supports listing files in working directory [patch provided]
Date Thu, 04 Jun 2009 12:11:07 GMT

    [ https://issues.apache.org/jira/browse/FTPSERVER-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716251#action_12716251
] 

David Latorre commented on FTPSERVER-287:
-----------------------------------------


By the way, PureFTPD and vsFTPD in Linux also seem to behave as described ( I didn't check
the $HOME option though). 

Still I also think that clients shouldn't rely on the output of the FTP server ... since you're
expecting that the output filename be equal to the nlist argument , why don't you use it in
your program? 

With your patch, what's the behaviour you get when you list a directory ? For example: NLIST
/myDir1/mydDir2 

Would return just the filenames ? or results of the kind: /myDir1/myDir2/file.txt ? 

" ls" and Pure-FTPD would return just the filenames ... so it is not very useful to have NLIST
return the full paths only sometimes. 

> NLST: Implementation only supports listing files in working directory [patch provided]
> --------------------------------------------------------------------------------------
>
>                 Key: FTPSERVER-287
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-287
>             Project: FtpServer
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1
>         Environment: Fedora 10-64bit and RH 5.2-64bit, Java 1.6.0_12-64 
>            Reporter: Dennis Keller
>             Fix For: 1.0.2, 1.1
>
>         Attachments: nlst.patch
>
>
> The NLST formatter, as implemented on trunk is insufficient to handle any request other
than a file within in the current working directory. Some examples:
> ftp> passive
> Passive mode on.
> ftp> nlist /directory/file.txt
> 227 Entering Passive Mode (127,0,0,1,179,241)
> 150 File status okay; about to open data connection.
> file.txt
> 226 Closing data connection.
> Other FTP servers return the following:
> ftp> passive
> Passive mode on.
> ftp> nlist /directory/file.txt
> 227 Entering Passive Mode (127,0,0,1,179,241)
> 150 File status okay; about to open data connection.
> /directory/file.txt
> 226 Closing data connection.
> Upon investigating, I found that the formatter will not handle absolute file requests,
parent directory request or non-absolute child directory requests. It does not error, it just
doesn't give useful output.
> I've modified the code to handle the cases that I could come up with, but there may be
other situations that need to be covered. I'm not an expert on the FTP specification (but
what I could find was not impressive), so there many be additional cases that need to be covered.
> Please consider the attached patch, with accompanying test cases

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message