mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Jakl <jakl.mich...@gmail.com>
Subject Re: svn commit: r791261 - /mina/sandbox/vysper/trunk/src/main/java/org/apache/vysper/xmpp/modules/extension/xep0060_pubsub/handler/PubSubCreateNodeHandler.java
Date Tue, 07 Jul 2009 09:48:57 GMT
Hi!

On Tue, Jul 7, 2009 at 11:21, Bernd Fondermann<bf_jak@brainlounge.de> wrote:
>> Don't trust the sender with the "to" address, use the one in the sessionContext.
>
> Now _you_ are getting overly defensive. ;-)
>
> If my mind serves me right, the to address has been checked before (in
> ProtocolWorker?), so it's save to use it. And I don't think
> getServerJID() will neccessarily give you the right one in every case
> either.

Currently it should (why not?), but as soon as we allow components to
have different domains it doesn't anymore.

Anyway, the JID for the module should be configured elsewhere, and not
take from the request. I'll fix that too tonight.

Michael

Mime
View raw message