mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Niklas Gustavsson <nik...@protocol7.com>
Subject Re: [vysper] cloning and forwarding stanzas
Date Tue, 01 Sep 2009 07:04:09 GMT
On Mon, Aug 31, 2009 at 7:40 PM,
bernd.fondermann<bernd.fondermann@brainlounge.de> wrote:
> Now there are convenience methods to replace 'to' and 'from' only in
>  StanzaBuilder.createForward(Stanza original, Entity from, Entity to)
> and
>  <T extends Stanza> T StanzaBuilder.createForwardStanza(
>                T original, Entity from, Entity to)

Great!

> I noticed that MUCMessageHandler's call to StanzaBuilder.createClone
> doesn't reuse the list in this way and re-creates it in the inner loop.
> We might want to change that.

We might. MUC is not optimized for performance (or much else besides
functionality) at this point. That being said, I'm not sure that
recreating the list is that much more expensive than reusing and
replacing.

/niklas

Mime
View raw message