mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bogdan Pistol (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIRMINA-754) Javadoc omission in IoFilterChain#fireMessageSent()
Date Fri, 08 Jan 2010 19:15:54 GMT

    [ https://issues.apache.org/jira/browse/DIRMINA-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798143#action_12798143
] 

Bogdan Pistol commented on DIRMINA-754:
---------------------------------------

You're right, the IoFilter#messageSent() better describes the event, the IoHandler#messageSent()
is called as consequence from the DefaultIoFilterChain#messageSent()

> Javadoc omission in IoFilterChain#fireMessageSent()
> ---------------------------------------------------
>
>                 Key: DIRMINA-754
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-754
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.0-RC1
>         Environment: N/A
>            Reporter: Bogdan Pistol
>            Priority: Trivial
>             Fix For: 2.0.0-RC2
>
>
> The javadoc of the org.apache.mina.core.filterchain.IoFilterChain#fireMessageSent() is
> /**
>  * Fires a {@link IoHandler#sessionOpened(IoSession)} event.  Most users don't need to
call
>  * this method at all.  Please use this method only when you implement a new transport
or
>  * fire a virtual event.
>  */
> public void fireMessageSent(WriteRequest request);
> And instead a better javadoc would be:
> /**
>  * Fires a {@link IoHandler#messageSent(IoSession, Object)} event.  Most users don't
need to call
>  * this method at all.  Please use this method only when you implement a new transport
or
>  * fire a virtual event.
>  */
> public void fireMessageSent(WriteRequest request);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message