mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan D. Cabrera" <l...@toolazydogs.com>
Subject Re: Not sure why...
Date Wed, 20 Jan 2010 04:52:05 GMT

On Jan 19, 2010, at 6:44 PM, Ashish wrote:

>>
>>> Well I think only Exception could be the only case needed. However,
>>> catching generic Exception means any error, a specific Exception
>>> caught is better.
>>
>> The other odd thing is that it catches the checked exception and  
>> wraps it in
>> a runtime exception.  This strikes me as a poor practice.
>>
>>> BTW, the catch(Error e) {} stuff has been caught by IntelliJ  
>>> Inspections.
>>>
>>> Just one more thing that I noted in the class, there are no log
>>> statements. Dom't we need them?
>>
>> I'm against logging exceptions if we're re-throwing them unless we  
>> print out
>> some critical piece of information that cannot be discerned by any  
>> other
>> method.  I say this from experience where I had to slog through  
>> millions of
>> log statements generated by one exception where every well meaning  
>> layer
>> printed something out.
>
> Alan, my comment was in general, not specific to Exception clause :-)
> The class doesn't have logging at all :-(

Duh.  I misread the post.  Sorry.  :(

You and I are of the same mind on this.  :)


Regards,
Alan


Mime
View raw message