mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan D. Cabrera" <l...@toolazydogs.com>
Subject Re: [MINA 3.0] Which filters should we keep ?
Date Sun, 10 Jan 2010 13:51:36 GMT

On Jan 10, 2010, at 1:59 AM, Julien Vermillard wrote:

> Le Sat, 9 Jan 2010 06:52:28 -0800,
> "Alan D. Cabrera" <list@toolazydogs.com> a écrit :
>> If it could not be done any other way I would agree with you but I
>> think that we all agree that the premise to using it at all is that
>> someone else poorly instrumented his code.  Plus it dilutes the
>> "regular" logging pattern that's already in use in most projects.
>> That's one of the problems with the Mina code base and accounts for
>> a significant amount of code bloat, that being everyone tacking on
>> orthogonal bits.
> +1
> For me a DEBUG statement in and out of each transformation filter  
> killed
> the use of LoggingFilter.
> But if the LoggingFilter is useful for some use, I don't mind if we
> keep it, it's a very thin bloat ;)

Apply "it's a very thin bloat" over and over and you end up w/ ...

Part of the discipline of library design is to remove possibly  
seemingly innocuous features that are used to promote bad practices.


View raw message