mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Latorre (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FTPSERVER-349) WhiteList
Date Mon, 08 Mar 2010 10:40:27 GMT

    [ https://issues.apache.org/jira/browse/FTPSERVER-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842621#action_12842621

David Latorre commented on FTPSERVER-349:

Hello  Devnull,

When i first revised your patch I noticed this problem. I considered some possibilities you
haven't mentioned: 
-1. In the method that adds the subnets/ips to the WhiteListFilter  (   updateWhitelistFilter(),
right?) we can remove the filter from the chain if we have an empty subnet list.

This would work but I'm concerned that ftpserver users may want to use WhiteListFilter when
it is not in the chain.

-2. Explictly  check for the address and consider it to mean "all addresses allowed".

If we move the WhiteListFilter to MINA-core, it might be worth discussing there how to signal
that "all addresses are allowed".

What do you think, Niklas?


> WhiteList
> ---------
>                 Key: FTPSERVER-349
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-349
>             Project: FtpServer
>          Issue Type: Improvement
>          Components: Server
>    Affects Versions: 1.0.3
>            Reporter: DevNull43
>            Priority: Trivial
>             Fix For: 1.1.0
>         Attachments: WhiteList.txt
> WhiteList filer
> Restricting access to FTP based on a WhiteList
> BlackList -> Allow all, Deny some.
> WhiteList -> Deny all, Allow some.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message