mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Genender <jgenen...@apache.org>
Subject Re: [VOTE] Release SSHD 0.4.0 (2nd try)
Date Wed, 05 May 2010 16:59:05 GMT
Gents,

Can we please change the topic of this email to a dev discussion... the [VOTE] in it is probably
not appropriate since [VOTE] indicates a real vote.  Thanks!

Jeff

On May 5, 2010, at 10:43 AM, Sai Pullabhotla wrote:

> Okay, I see the fix for the dates, but they are still incorrect when
> the client interprets its. Couple of things -
> 
> I believe time should be on a 24 hour clock basis - so the format need
> to be changed to HH instead of hh.
> 
> The listing is not compatible with UNIX style listing. So files older
> than 6 months should show the year, but not the time. Files in the
> last 6 months should show time, but not year. Unless SFTP has a
> standard for the directory list format.
> 
> In essence, FileZilla shows a file that is modified in year 2006 as 2010.
> 
> There is some code in the FtpServer project that we may want to steal.
> It is org.apache.ftpserver.util.DateUtils.getUnixDate(long).
> 
> 
> Regards,
> Sai Pullabhotla
> 
> 
> 
> 
> 
> On Wed, May 5, 2010 at 11:15 AM, Guillaume Nodet <gnodet@gmail.com> wrote:
>> Which dates ? I've fixed the "Jan 01 ..." thing if that's why you're
>> referring to.
>> But using filezilla, there are still things that we don't support, but i've
>> been able to download directories recursively without problems.
>> 
>> On Wed, May 5, 2010 at 17:49, Sai Pullabhotla
>> <sai.pullabhotla@jmethods.com>wrote:
>> 
>>> How about the dates on the files?
>>> 
>>> Regards,
>>> Sai Pullabhotla
>>> 
>>> 
>>> 
>>> 
>>> 
>>> On Wed, May 5, 2010 at 10:13 AM, Guillaume Nodet <gnodet@gmail.com> wrote:
>>>> Fixed, let me know if you find any other easily fixed issues.
>>>> 
>>>> On Wed, May 5, 2010 at 16:41, Sai Pullabhotla
>>>> <sai.pullabhotla@jmethods.com>wrote:
>>>> 
>>>>> I just noticed that the code checked in just replaces "\" with "/". I
>>>>> think for best compliance on all operating systems and file systems,
>>>>> it should replace File.separatorChar with "/". Not sure if there are
>>>>> any file systems that use a separator other than "/" and "\".
>>>>> 
>>>>> Regards,
>>>>> Sai Pullabhotla
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> On Wed, May 5, 2010 at 9:22 AM, Guillaume Nodet <gnodet@gmail.com>
>>> wrote:
>>>>>> I've committed the changes.  Could you give a try ?
>>>>>> 
>>>>>> On Wed, May 5, 2010 at 16:20, Guillaume Nodet <gnodet@gmail.com>
>>> wrote:
>>>>>> 
>>>>>>> Removing the second string works with FileZilla but fails with
the
>>> sftp
>>>>>>> command line utility.
>>>>>>> 
>>>>>>> 
>>>>>>> On Wed, May 5, 2010 at 16:13, Guillaume Nodet <gnodet@gmail.com>
>>> wrote:
>>>>>>> 
>>>>>>>> Yeah, that's what I'm trying.
>>>>>>>> Let me try with removing the double name though.
>>>>>>>> 
>>>>>>>> 
>>>>>>>> On Wed, May 5, 2010 at 15:50, Sai Pullabhotla <
>>>>>>>> sai.pullabhotla@jmethods.com> wrote:
>>>>>>>> 
>>>>>>>>> How about something like this:
>>>>>>>>> 
>>>>>>>>>    protected void sendAbsoluteName(int id, File file)
throws
>>>>> IOException
>>>>>>>>> {
>>>>>>>>>        Buffer buffer = new Buffer();
>>>>>>>>>        buffer.putByte((byte) SSH_FXP_NAME);
>>>>>>>>>        buffer.putInt(id);
>>>>>>>>>        buffer.putInt(1);
>>>>>>>>>        String path = file.getPath();
>>>>>>>>>        if(File.separatorChar != '/') {
>>>>>>>>>            path = path.replace(File.separatorChar, '/');
>>>>>>>>>        }
>>>>>>>>>        if(path.charAt(0) != '/') {
>>>>>>>>>            path = '/' + path;
>>>>>>>>>        }
>>>>>>>>>        buffer.putString(path);
>>>>>>>>>        //buffer.putString(file.getPath());
>>>>>>>>>        writeAttrs(buffer, file);
>>>>>>>>>        send(buffer);
>>>>>>>>>    }
>>>>>>>>> 
>>>>>>>>> Regards,
>>>>>>>>> Sai Pullabhotla
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> On Wed, May 5, 2010 at 8:45 AM, Sai Pullabhotla
>>>>>>>>> <sai.pullabhotla@jmethods.com> wrote:
>>>>>>>>>> I removed the second call to place the path in the
buffer and
>>> seems
>>>>> to
>>>>>>>>>> be working fine.
>>>>>>>>>> 
>>>>>>>>>> Regards,
>>>>>>>>>> Sai Pullabhotla
>>>>>>>>>> 
>>>>>>>>> 
>>>>>>>> 
>>>>>>>> 
>>>>>>>> 
>>>>>>>> --
>>>>>>>> Cheers,
>>>>>>>> Guillaume Nodet
>>>>>>>> ------------------------
>>>>>>>> Blog: http://gnodet.blogspot.com/
>>>>>>>> ------------------------
>>>>>>>> Open Source SOA
>>>>>>>> http://fusesource.com
>>>>>>>> 
>>>>>>>> 
>>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> --
>>>>>>> Cheers,
>>>>>>> Guillaume Nodet
>>>>>>> ------------------------
>>>>>>> Blog: http://gnodet.blogspot.com/
>>>>>>> ------------------------
>>>>>>> Open Source SOA
>>>>>>> http://fusesource.com
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> --
>>>>>> Cheers,
>>>>>> Guillaume Nodet
>>>>>> ------------------------
>>>>>> Blog: http://gnodet.blogspot.com/
>>>>>> ------------------------
>>>>>> Open Source SOA
>>>>>> http://fusesource.com
>>>>>> 
>>>>> 
>>>> 
>>>> 
>>>> 
>>>> --
>>>> Cheers,
>>>> Guillaume Nodet
>>>> ------------------------
>>>> Blog: http://gnodet.blogspot.com/
>>>> ------------------------
>>>> Open Source SOA
>>>> http://fusesource.com
>>>> 
>>> 
>> 
>> 
>> 
>> --
>> Cheers,
>> Guillaume Nodet
>> ------------------------
>> Blog: http://gnodet.blogspot.com/
>> ------------------------
>> Open Source SOA
>> http://fusesource.com
>> 


Mime
View raw message