mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maarten Bosteels (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (DIRMINA-784) Error with MDCInjectionFilter on Windows
Date Mon, 10 May 2010 07:29:47 GMT

    [ https://issues.apache.org/jira/browse/DIRMINA-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865685#action_12865685
] 

Maarten Bosteels edited comment on DIRMINA-784 at 5/10/10 3:28 AM:
-------------------------------------------------------------------

Hello Ashish,

I was also able to reproduce the problem on my machine, without changing any timeouts.

And I think I have found the cause(s) of the test failure. I will try to commit a fix tonight.

Problems:
* the test uses a custom appender to collect logging events, these logging events are checked
for MDC values at the end of every test
* but this list of events is never cleared => the events from test1 are still present when
test2 starts
* but just clearing the events at the end of every test is not enough to solve the issue
  because the tests don't wait until all thread pools are completey shut down => sometimes
events from test1 are generated when test2 is already running
* the session-closed event that you see are generated by a previous test 

After a quick search I couldn't find an easy way to wait until threadpools are shut down.
The NioSocketConnector is disposed on line 226, but this method does not block until executor
is shut down:  
AbstractIoService.dispose() calls executor.shutdownNow but is used to wait until termination


      was (Author: mbosteels):
    Hello Ashish,

I was also able to reproduce the problem on my machine, without changing any timeouts.

And I think I have found the cause(s) of the test failure. I will try to commit a fix tonight.

Problems:
* the test uses a custom appender to collect logging events, these logging events are checked
for MDC values at the end of every test
* but this list of events is never cleared => the events from test1 are still present when
test2 starts
* but just clearing the events at the end of every test is not enough to solve the issue
  because the tests don't wait until all thread pools are completey shut down => sometimes
events from test1 are generated when test2 is already running

After a quick search I couldn't find an easy way to wait until threadpools are shut down.
The NioSocketConnector is disposed on line 226, but this method does not block until executor
is shut down:  
AbstractIoService.dispose() calls executor.shutdownNow but is used to wait until termination

  
> Error with MDCInjectionFilter on Windows
> ----------------------------------------
>
>                 Key: DIRMINA-784
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-784
>             Project: MINA
>          Issue Type: Bug
>    Affects Versions: 2.0.0-RC1
>            Reporter: Emmanuel Lecharny
>            Assignee: Ashish Paliwal
>             Fix For: 2.0.0
>
>
> One test is randomly failing on Windows only :
> http://hudson.zones.apache.org/hudson/job/MINA-trunk-jdk1.6-windows/lastBuild/org.apache.mina$mina-core/testReport/org.apache.mina.filter.logging/MdcInjectionFilterTest/testOnlyRemoteAddress/
> It may be the test which is broken, or something we added since the last version, as
it was working in 2.0.0-RC1

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message