mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guillaume Nodet <gno...@gmail.com>
Subject Re: [VOTE] Release SSHD 0.4.0 (2nd try)
Date Wed, 05 May 2010 15:13:31 GMT
Fixed, let me know if you find any other easily fixed issues.

On Wed, May 5, 2010 at 16:41, Sai Pullabhotla
<sai.pullabhotla@jmethods.com>wrote:

> I just noticed that the code checked in just replaces "\" with "/". I
> think for best compliance on all operating systems and file systems,
> it should replace File.separatorChar with "/". Not sure if there are
> any file systems that use a separator other than "/" and "\".
>
> Regards,
> Sai Pullabhotla
>
>
>
>
>
> On Wed, May 5, 2010 at 9:22 AM, Guillaume Nodet <gnodet@gmail.com> wrote:
> > I've committed the changes.  Could you give a try ?
> >
> > On Wed, May 5, 2010 at 16:20, Guillaume Nodet <gnodet@gmail.com> wrote:
> >
> >> Removing the second string works with FileZilla but fails with the sftp
> >> command line utility.
> >>
> >>
> >> On Wed, May 5, 2010 at 16:13, Guillaume Nodet <gnodet@gmail.com> wrote:
> >>
> >>> Yeah, that's what I'm trying.
> >>> Let me try with removing the double name though.
> >>>
> >>>
> >>> On Wed, May 5, 2010 at 15:50, Sai Pullabhotla <
> >>> sai.pullabhotla@jmethods.com> wrote:
> >>>
> >>>> How about something like this:
> >>>>
> >>>>    protected void sendAbsoluteName(int id, File file) throws
> IOException
> >>>> {
> >>>>        Buffer buffer = new Buffer();
> >>>>        buffer.putByte((byte) SSH_FXP_NAME);
> >>>>        buffer.putInt(id);
> >>>>        buffer.putInt(1);
> >>>>        String path = file.getPath();
> >>>>        if(File.separatorChar != '/') {
> >>>>            path = path.replace(File.separatorChar, '/');
> >>>>        }
> >>>>        if(path.charAt(0) != '/') {
> >>>>            path = '/' + path;
> >>>>        }
> >>>>        buffer.putString(path);
> >>>>        //buffer.putString(file.getPath());
> >>>>        writeAttrs(buffer, file);
> >>>>        send(buffer);
> >>>>    }
> >>>>
> >>>> Regards,
> >>>> Sai Pullabhotla
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>> On Wed, May 5, 2010 at 8:45 AM, Sai Pullabhotla
> >>>> <sai.pullabhotla@jmethods.com> wrote:
> >>>> > I removed the second call to place the path in the buffer and seems
> to
> >>>> > be working fine.
> >>>> >
> >>>> > Regards,
> >>>> > Sai Pullabhotla
> >>>> >
> >>>>
> >>>
> >>>
> >>>
> >>> --
> >>> Cheers,
> >>> Guillaume Nodet
> >>> ------------------------
> >>> Blog: http://gnodet.blogspot.com/
> >>> ------------------------
> >>> Open Source SOA
> >>> http://fusesource.com
> >>>
> >>>
> >>>
> >>
> >>
> >> --
> >> Cheers,
> >> Guillaume Nodet
> >> ------------------------
> >> Blog: http://gnodet.blogspot.com/
> >> ------------------------
> >> Open Source SOA
> >> http://fusesource.com
> >>
> >>
> >>
> >
> >
> > --
> > Cheers,
> > Guillaume Nodet
> > ------------------------
> > Blog: http://gnodet.blogspot.com/
> > ------------------------
> > Open Source SOA
> > http://fusesource.com
> >
>



-- 
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message