mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIRMINA-815) CumulativeProtocolDecoder.decode(...) does not find previous buffer
Date Tue, 11 Jan 2011 16:57:45 GMT

    [ https://issues.apache.org/jira/browse/DIRMINA-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980181#action_12980181
] 

Emmanuel Lecharny commented on DIRMINA-815:
-------------------------------------------

I would not be as vocal as you are, because every java class inherit from Object, which has
a hashCode() method implemented, but basically, you are right : this is a smell, and the AttributeKey
class *must* have a hashcode() *and* an equals() method.

Which version are you testing ?

> CumulativeProtocolDecoder.decode(...) does not find previous buffer
> -------------------------------------------------------------------
>
>                 Key: DIRMINA-815
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-815
>             Project: MINA
>          Issue Type: Bug
>         Environment: any
>            Reporter: Siro Mateos
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> CumulativeProtocolDecoder does not find previous input buffer stored in 'session.attributes'
(see 'CumulativeProtocolDecoder.java', line 136), probably because 'attributes' uses a ConcurrentHashMap,
and class AttributeKey does NOT implement hashCode(), rendering CumulativeProtocolDecoder
useless.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message