mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Will Glass-Husain <wglasshus...@gmail.com>
Subject Re: [VOTE] Release Mina SSHD 0.6.0 (3rd try)
Date Tue, 06 Sep 2011 19:12:37 GMT
Ok. I change my (non binding) vote to 0. It makes me uneasy but seems minor.  Maybe I'll dig
into it later, try to fix it. 

Will

On Sep 6, 2011, at 2:50 PM, Guillaume Nodet <gnodet@gmail.com> wrote:

> Yeah, the test usually passes for me, but it sometimes fail.  I'm not
> too worried about those tests, as it's been like that for some time
> now and it not seem to reflect any real issue in the code base.
> 
> On Tue, Sep 6, 2011 at 17:35, Will Glass-Husain <wglasshusain@gmail.com> wrote:
>> I added sleep's and it still failed.  Does it pass for you?  I'm wondering
>> if it's a Windows issue.  It fails on the assert in the last line below.
>> 
>> 
>>    @Test
>>    public void testReadWriteWithOffset() throws Exception {
>>        File root = new File("target/scp");
>>        File target = new File("target/scp/out.txt");
>>        root.mkdirs();
>>        assertTrue(root.exists());
>> 
>>        Thread.sleep(500);
>> 
>>        ChannelSftp c = (ChannelSftp) session.openChannel("sftp");
>>        Thread.sleep(500);
>>        c.connect();
>>        Thread.sleep(500);
>> 
>>        c.put(new ByteArrayInputStream("0123456789".getBytes()),
>> target.getPath());
>> 
>>        Thread.sleep(500);
>>        assertTrue(target.exists());
>> 
>> 
>> On Tue, Sep 6, 2011 at 3:09 AM, Guillaume Nodet <gnodet@gmail.com> wrote:
>> 
>>> I think the test sftp and scp tests sometimes have problems, but afaik
>>> their failure don't really reflect a problem in the code base, but
>>> rather in the tests themselves.
>>> I wonder if adding a small sleep before the failing assertion would help.
>>> 
>>> On Tue, Sep 6, 2011 at 06:53, Will Glass-Husain <wglasshusain@gmail.com>
>>> wrote:
>>>> Hi Guillaume,
>>>> 
>>>> -1 from me.
>>>> 
>>>> When I run
>>>> mvn clean package
>>>> 
>>>> from the zipped source package, I get a failed test, specifically
>>>> org.apache.sshd.SftpTest.testReadWriteWithOffset
>>>> 
>>>> 
>>> -------------------------------------------------------------------------------
>>>> Test set: org.apache.sshd.SftpTest
>>>> 
>>> -------------------------------------------------------------------------------
>>>> Tests run: 3, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 0.352 sec
>>>> <<< FAILURE!
>>>> testReadWriteWithOffset(org.apache.sshd.SftpTest)  Time elapsed: 0.124
>>> sec
>>>> <<< FAILURE!
>>>> java.lang.AssertionError:
>>>>    at org.junit.Assert.fail(Assert.java:74)
>>>>    at org.junit.Assert.assertTrue(Assert.java:37)
>>>>    at org.junit.Assert.assertTrue(Assert.java:46)
>>>>    at org.apache.sshd.SftpTest.testReadWriteWithOffset(SftpTest.java:158)
>>>> 
>>>> Running on Win 7, Java 6, Maven 2.2.1
>>>> 
>>>> Other stuff I checked that worked
>>>> - tars and zips matched
>>>> - md5s matched.
>>>> 
>>>> Happy to be part of this process-- don't mind rechecking again later.
>>>> 
>>>> WILL
>>>> 
>>>> P.S.
>>>> 
>>>> On Mon, Sep 5, 2011 at 1:28 PM, Jeff Genender <jgenender@apache.org>
>>> wrote:
>>>> 
>>>>> +1
>>>>> 
>>>>> Jeff
>>>>> 
>>>>> 
>>>>> On Sep 5, 2011, at 11:03 AM, Guillaume Nodet wrote:
>>>>> 
>>>>>> 3nd try for the release of SSHD 0.6.0.
>>>>>> I've fixed the missing header and removed the duplicate source
>>>>>> distribution from the staging repo.
>>>>>> 
>>>>>> A number of issues have been fixed:
>>>>>> 
>>>>> 
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12315514
>>>>>> 
>>>>>> The staging repo is available at:
>>>>>> https://repository.apache.org/content/repositories/orgapachemina-030/
>>>>>> 
>>>>>> Source and binary distributions are available at:
>>>>>> 
>>>>> 
>>> https://repository.apache.org/content/repositories/orgapachemina-030/org/apache/sshd/apache-sshd/0.6.0/
>>>>>> 
>>>>>> The svn tag is:
>>>>>> http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.6.0/
>>>>>> at revision 1165357
>>>>>> http://svn.apache.org/viewvc?view=revision&revision=1165357
>>>>>> 
>>>>>> Please review and vote:
>>>>>> [ ] +1 Release SSHD 0.6.0
>>>>>> [ ] -1 Do not
>>>>>> 
>>>>>> --
>>>>>> ------------------------
>>>>>> Guillaume Nodet
>>>>>> ------------------------
>>>>>> Blog: http://gnodet.blogspot.com/
>>>>>> ------------------------
>>>>>> Open Source SOA
>>>>>> http://fusesource.com
>>>>> 
>>>>> 
>>>> 
>>> 
>>> 
>>> 
>>> --
>>> ------------------------
>>> Guillaume Nodet
>>> ------------------------
>>> Blog: http://gnodet.blogspot.com/
>>> ------------------------
>>> Open Source SOA
>>> http://fusesource.com
>>> 
>> 
> 
> 
> 
> -- 
> ------------------------
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> Open Source SOA
> http://fusesource.com

Mime
View raw message