mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guillaume Nodet <gno...@gmail.com>
Subject Re: [CANCEL] [VOTE] Release Mina SSHD 0.6.0 (2nd try)
Date Mon, 05 Sep 2011 16:07:42 GMT
No, slf4j-api is mandatory as a a transitive dependency of mina-core
while slf4j-log4j is flagged as test.

On Mon, Sep 5, 2011 at 17:35, sebb <sebbaz@gmail.com> wrote:
> On 5 September 2011 16:23, Guillaume Nodet <gnodet@gmail.com> wrote:
>> Cancelling this vote due to the missing AL header.
>>
>> On the optional dependecies, slf4j-api is actually mandatory.  Also
>
> So is that a bug in the POM?
>
>> slf4j requires one implementation at runtime, so we include
>> slf4j-simple (though we use slf4j-log4j in the tests).   Bouncycastle
>> and apr are included, because even if they are optional, they do
>> provide some important features.  For jpam, I don't think anyone is
>> really using the pam module, so I'm not sure why we'd have to include
>> the dependency.  And if you ask why it is included, iirc it's because
>> some people found odd that one artifact was not included in the binary
>> distribution I think.
>>
>>
>> On Mon, Sep 5, 2011 at 16:41, sebb <sebbaz@gmail.com> wrote:
>>> On 5 September 2011 10:39, Guillaume Nodet <gnodet@gmail.com> wrote:
>>>> 2nd try for the release of SSHD 0.6.0.
>>>> The legal files have been fixed and empty dirs removed, no other changes.
>>>>
>>>> A number of issues have been fixed:
>>>>  https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12315514
>>>>
>>>> The staging repo is available at:
>>>>  https://repository.apache.org/content/repositories/orgapachemina-024/
>>>
>>> I checked
>>> https://repository.apache.org/content/repositories/orgapachemina-028/
>>>
>>>> Source and binary distributions are available at:
>>>>  https://repository.apache.org/content/repositories/orgapachemina-024/org/apache/sshd/apache-sshd/0.6.0/
>>>
>>> I checked:
>>> https://repository.apache.org/content/repositories/orgapachemina-028/org/apache/sshd/apache-sshd/0.6.0/
>>>
>>> It's very confusing to have two source archives.
>>>
>>> I suggest you delete sshd-0.6.0-source-release.zip from the release, i.e. delete
>>> https://repository.apache.org/content/repositories/orgapachemina-028/org/apache/sshd/sshd/
>>>
>>> The binary archive content is a bit odd as well.
>>> Why include slf4j but not JCraft? They both have test scope, as far as
>>> I can tell.
>>> Also, why include bouncy castle and tomcat but not jcraft/jzlib (all optional)?
>>> Why not include net.sj.jpam, which is required by sshd-pam?
>>>
>>>> The svn tag is:
>>>>  http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.6.0/
>>>
>>> Lots of missing SVN eol-style settings. See
>>> https://issues.apache.org/jira/browse/SSHD-143
>>> Not a blocker.
>>>
>>> No AL header in the file:
>>> sshd-core/src/main/java/org/apache/sshd/server/HandshakingUserAuth.java
>>>
>>>
>>>> Please review and vote:
>>>>  [ ] +1 Release SSHD 0.6.0
>>>>  [X] -1 Do not
>>>>
>>>>
>>>> --
>>>> ------------------------
>>>> Guillaume Nodet
>>>> ------------------------
>>>> Blog: http://gnodet.blogspot.com/
>>>> ------------------------
>>>> Open Source SOA
>>>> http://fusesource.com
>>>
>>
>>
>>
>> --
>> ------------------------
>> Guillaume Nodet
>> ------------------------
>> Blog: http://gnodet.blogspot.com/
>> ------------------------
>> Open Source SOA
>> http://fusesource.com
>>
>



-- 
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com

Mime
View raw message