mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [VOTE] Release SSHD 0.6.0
Date Mon, 05 Sep 2011 01:41:33 GMT
On 4 September 2011 21:03, Guillaume Nodet <gnodet@gmail.com> wrote:
> On Sun, Sep 4, 2011 at 14:22, sebb <sebbaz@gmail.com> wrote:
>> On 4 September 2011 07:42, Guillaume Nodet <gnodet@gmail.com> wrote:
>>> The source distribution is available at
>>>
>>> https://repository.apache.org/content/repositories/orgapachemina-016/org/apache/sshd/apache-sshd/0.6.0/apache-sshd-0.6.0-src.tar.gz
>>
>> That has a different directory structure from SVN.
>
> And so ?

Most other projects use the same structure for both; this means users
can use the source archive to build the code.
If they then want to build from the current trunk, they can do so in
the same manner.

Different structures means different build procedures.

> Everything is in the src folder.  The main reason is that people can
> unzip both the binary and source distribution in the same location
> without messing both.

That's true for most other projects without needing to change the
directory structure;
When building the code in an SVN workspace, the output files are
normally in a different part of the structure (i.e. target in Maven
builds) so do not interfere.

>>
>> Also it does not include resources, pam or util.

Turns out these are empty SVN directories, so no wonder they don't
affect the builds.

>>
>
> These archives contains a buildable source tree.  I've just extracted
> and build the artifacts locally so I don't think anything is missing.
>
>> The file sshd-0.6.0-source-release.zip does match SVN, but there is no
>> corresponding tar.gz file.
>
> I'm not sure where this file come from.  I mean I'm used to look at
> the one I pointed above.
> And anyway, that one builds fine too for me.
>
>> There should be one source archive, in zip and tar.gz formats, which
>> should correspond with the SVN tag (except perhaps for the DOAP file
>> and one or two others that only belong in SVN).
>
> Where does this policy come from?  The source archive does not need to
> map to a svn tag and the format zip + tar.gz is purely for ease of
> use.

Source archives should not contain anything that is not in SVN.
This is because SVN is used for tracing provenance.
Generally everything in SVN needs to be in the source archive.
Therefore the two need to agree.

Agreed you don't need to create both tar.gz and zip, but given that
all the other archives are have both, it seems sensible to do so here
as well.

It's confusing to have two zip source archives and only one tar.gz archive.

==

There's another issue with the NOTICE and LICENSE files.
The binary distribution includes 2 slf4j jars, but the NOTICE and
LICENSE files don't mention it.

I would expect to see the full slf4j license in the LICENSE file, and
NOTICE should contain the required notice, i.e.

This product includes software SLF4J (www.slf4j.org)
Copyright (c) 2004-2008 QOS.ch All rights reserved.

Also, the binary NOTICE mentions JCraft, but there does not seem to be
a JCraft jar anywhere.
If it is not included in the release, it should not be mentioned in
the NOTICE file

>>> On Sunday, September 4, 2011, sebb <sebbaz@gmail.com> wrote:
>>>> The file:
>>>>
>>>> src/main/java/org/apache/sshd/server/HandshakingUserAuth.java
>>>>
>>>> does not have an AL header.
>>>>
>>>> There does not seem to be a tar.gz version of the full source.
>>>>
>>>> On 2 September 2011 17:58, sebb <sebbaz@gmail.com> wrote:
>>>>> The NOTICE file is wrong.
>>>>>
>>>>> It should start with:
>>>>>
>>>>> Apache MINA SSHD
>>>>> Copyright 2xxx-2011 The Apache Software Foundation
>>>>>
>>>>> This product includes software developed by
>>>>> The Apache Software Foundation (http://www.apache.org/).
>>>>>
>>>>> The rest of the NOTICE file is for *required* notices of software that
>>>>> is included in the release.
>>>>>
>>>>> It should not contain the license text; which should be in the LICENSE
>>> file
>>>>>
>>>>> Have a look at the httpd ones for an example.
>>>>>
>>>>> http://svn.apache.org/repos/asf/httpd/httpd/trunk/
>>>>>
>>>>> These are blockers.
>>>>>
>>>>> Sorry, don't have time to check for AL headers at present.
>>>>>
>>>>> On 2 September 2011 14:18, Guillaume Nodet <gnodet@gmail.com> wrote:
>>>>>> Sorry, here is the tag:
>>>>>>  http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.6.0/
>>>>>>
>>>>>> On Fri, Sep 2, 2011 at 15:07, Emmanuel Lecharny <elecharny@gmail.com>
>>> wrote:
>>>>>>> On 9/2/11 11:19 AM, Guillaume Nodet wrote:
>>>>>>>>
>>>>>>>> A vote for this long overdue release of SSHD 0.6.0 which
contains a
>>>>>>>> bunch of improvements and bug fixes.
>>>>>>>>
>>>>>>>> A number of issues have been fixed:
>>>>>>>>
>>>>>>>>
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12315514
>>>>>>>>
>>>>>>>> The staging repo is available at:
>>>>>>>>
>>> https://repository.apache.org/content/repositories/orgapachemina-016/
>>>>>>>>
>>>>>>>> Please review and vote:
>>>>>>>>  [ ] +1 Release SSHD 0.6.0
>>>>>>>>  [ ] -1 Do not
>>>>>>>>
>>>>>>> Revision ?
>>>>>>>
>>>>>>> --
>>>>>>> Regards,
>>>>>>> Cordialement,
>>>>>>> Emmanuel Lécharny
>>>>>>> www.iktek.com
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> ------------------------
>>>>>> Guillaume Nodet
>>>>>> ------------------------
>>>>>> Blog: http://gnodet.blogspot.com/
>>>>>> ------------------------
>>>>>> Open Source SOA
>>>>>> http://fusesource.com
>>>>>>
>>>>>
>>>>
>>>
>>> --
>>> ------------------------
>>> Guillaume Nodet
>>> ------------------------
>>> Blog: http://gnodet.blogspot.com/
>>> ------------------------
>>> Open Source SOA
>>> http://fusesource.com
>>>
>>
>
>
>
> --
> ------------------------
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> Open Source SOA
> http://fusesource.com
>

Mime
View raw message