mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guillaume Nodet (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SSHD-145) InvertedShellWrapper may not send process output back if process exits too fast
Date Sat, 19 May 2012 12:36:09 GMT

     [ https://issues.apache.org/jira/browse/SSHD-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Guillaume Nodet resolved SSHD-145.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.7.0
         Assignee: Guillaume Nodet

Patch applied.  Thx a ton Denis and Pierre.
                
> InvertedShellWrapper may not send process output back if process exits too fast
> -------------------------------------------------------------------------------
>
>                 Key: SSHD-145
>                 URL: https://issues.apache.org/jira/browse/SSHD-145
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 0.5.0
>         Environment: Usually does not reproduce on windows, often on linux (Ubuntu 11.04)
>            Reporter: Denis Tulskiy
>            Assignee: Guillaume Nodet
>            Priority: Minor
>             Fix For: 0.7.0
>
>         Attachments: patch-with-test.patch
>
>
> In InvertedShellWrapper, pumpStreams() method first checks if the process is alive, and
only then pumps streams. It could happen that after the process has already exited, some information
is left out in out or err streams. Moving the check for shell.isAlive() after all pumpStream()
calls seems to resolve the issue.
> I've uploaded a patch for your convenience here https://gist.github.com/1206056
> steps to reproduce:
> 1. create a default server
> 2. set command factory as described at http://mina.apache.org/sshd/tips.html
> 3. run `ssh localhost -p 8000 echo test`
> expected result:
> command output is `test`
> actual result:
> usually nothing is printed even though the command is executed

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message