mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guillaume Nodet (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SSHD-153) Improve handling of SSH_MSG_CHANNEL_WINDOW_ADJUST message
Date Mon, 21 May 2012 08:25:41 GMT

     [ https://issues.apache.org/jira/browse/SSHD-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Guillaume Nodet resolved SSHD-153.
----------------------------------

    Resolution: Fixed
      Assignee: Guillaume Nodet

Fixed, thx for the patch Simon.
                
> Improve handling of SSH_MSG_CHANNEL_WINDOW_ADJUST message
> ---------------------------------------------------------
>
>                 Key: SSHD-153
>                 URL: https://issues.apache.org/jira/browse/SSHD-153
>             Project: MINA SSHD
>          Issue Type: Improvement
>         Environment: All
>            Reporter: Simon Paradis
>            Assignee: Guillaume Nodet
>            Priority: Trivial
>              Labels: patch
>             Fix For: 0.7.0
>
>         Attachments: ssh_window_adjustment_patch.diff
>
>
> I posted about this issue in the users mailing list...
> The consumeAndCheck() method of channel/Window.java is used to enlarge the receive window
of channel. While tracing a libssh2 based application with tracing enabled talking to a SSHD-Core
Java app, I found out it sends too many of these adjustment message. It was sending one every
3 packet size which is quite too much considering the default packet size of 32kb. 
> The RFC 4254 is unclear about proper handling but sending one when the current window
size reaches half of its maximum look common. This is what OpenSSH
> I've attached a patch taken from the trunk http://svn.apache.org/repos/asf/mina/sshd/trunk

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message