mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Kuker (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SSHD-121) Add Factories to create IoAcceptors for TcpipForwardSupport & X11ForwardSupport
Date Thu, 20 Sep 2012 18:18:07 GMT

    [ https://issues.apache.org/jira/browse/SSHD-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459823#comment-13459823
] 

Bill Kuker commented on SSHD-121:
---------------------------------

Yes, here is why:

I use this to restrict the IPs that are allowed to use a port forward, once that forward has
been established. Each "User" who is logged in, identified by their ServerSession, has a list
of IPs that are allowed to use the PortForwards that user creates.

I had implemented this as part of TcpIpPortForwardFilter when I did it myself, but the patch
as I submitted is more generally useful to others, as it allows one to set up any filters
they want.
                
> Add Factories to create IoAcceptors for TcpipForwardSupport & X11ForwardSupport
> -------------------------------------------------------------------------------
>
>                 Key: SSHD-121
>                 URL: https://issues.apache.org/jira/browse/SSHD-121
>             Project: MINA SSHD
>          Issue Type: Improvement
>    Affects Versions: 0.6.0
>            Reporter: Bill Kuker
>            Assignee: Guillaume Nodet
>            Priority: Minor
>             Fix For: 0.7.0
>
>         Attachments: SSHD-121-Proposal.patch
>
>
> I would like to make it possible for applications embedding Mina SSHD to have greater
control over the IoAcceptors used by port forwards. I will do the work and submit a patch
if this effort seems valuable to the project.
> I would like to add these methods to the ServerFactoryManager interface:
>     ForwardingAcceptorFactory getTcpipForwardNioSocketAcceptorFactory();
>     ForwardingAcceptorFactory getX11ForwardNioSocketAcceptorFactory();
> Create an Interface ForwardingAcceptorFactory with:
>     public NioSocketAcceptor createNioSocketAcceptor(ServerSession ss);
> Use the ForwardingAcceptorFactory in TcpipForwardSupport and X11ForwardSupport.
> Implement a DefaultForwardingAcceptorFactory to be used by default.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message