mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DIRMINA-629) The IoServiceStatistics methods are called for every new session creation
Date Wed, 10 Oct 2012 11:15:05 GMT

     [ https://issues.apache.org/jira/browse/DIRMINA-629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Emmanuel Lecharny updated DIRMINA-629:
--------------------------------------

    Fix Version/s:     (was: 2.0.6)
                   2.0.8
    
> The IoServiceStatistics methods are called for every new session creation
> -------------------------------------------------------------------------
>
>                 Key: DIRMINA-629
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-629
>             Project: MINA
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-M3
>            Reporter: Emmanuel Lecharny
>            Priority: Minor
>             Fix For: 2.0.8
>
>
> When a session is established, some methods of the IoServiceStatistics class are called
:
>     protected final void finishSessionInitialization(IoSession session, IoFuture future,
IoSessionInitializer sessionInitializer) {
>         if (stats.getLastReadTime() == 0) {
>             ((IoServiceStatistics)stats).setLastReadTime(getActivationTime());
> There are two problems with this approach :
> - first, many of the members of this classes are not thread safe, leading to some random
value potentially be put into the stats instance for the service
> - second, if we protect those members using some synchronization (or volatile data),
it might slow down the connection initialization.
> The IoServiceStatistics class should be thread safe, and these statistics should not
be updated if the user don't want them, ie, it should be optionnal (the Configuration object
should take care of this)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message