mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew C (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SSHD-218) Can DefaultSshFuture.cancel() et.al. can all be deleted?
Date Sat, 18 May 2013 11:47:15 GMT

    [ https://issues.apache.org/jira/browse/SSHD-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661342#comment-13661342
] 

Andrew C commented on SSHD-218:
-------------------------------

Ah, that explains it.  I couldn't find any test code, so assumed it wasn't needed.  Neither
SSHD-220 and SSHD-221 depend on this being removed (although I'm not sure what would happen
if cancel() was called).
                
> Can DefaultSshFuture.cancel() et.al. can all be deleted?
> --------------------------------------------------------
>
>                 Key: SSHD-218
>                 URL: https://issues.apache.org/jira/browse/SSHD-218
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 0.8.0
>            Reporter: Andrew C
>
> Stumbled across this.
> Turns out the only call to cancel(), for any *Future class, is in SshClient.connect(SocketAddress)
with:
>     if (future.isCanceled()) {
>         connectFuture.cancel();
> which is pretty circular ...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message