mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Heemskerk (JIRA)" <j...@apache.org>
Subject [jira] [Created] (SSHD-253) Improve performance of auth and idle timeout checking
Date Fri, 30 Aug 2013 11:25:51 GMT
Michael Heemskerk created SSHD-253:
--------------------------------------

             Summary: Improve performance of auth and idle timeout checking
                 Key: SSHD-253
                 URL: https://issues.apache.org/jira/browse/SSHD-253
             Project: MINA SSHD
          Issue Type: Improvement
            Reporter: Michael Heemskerk
            Priority: Minor


SshServer performs auth and idle timeout checks by scheduling a Runnable to disconnect the
session when the timeout occurs. Every time new data is received, the task is canceled and
a new Runnable is scheduled.

As a result ScheduledExecutorService.schedule is called very frequently and pops up in the
profiling hotspots.  I've created an alternative implementation that uses a single thread
to periodically checks (once every second) all active sessions whether they've timed out.


The performance impact of this change depends on the type of SSH usage. For operations that
transfer a lot of data in a short time, the improvement is significant (about 8% in my test).

I'll open a PR on github shortly

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message