mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guillaume Nodet (JIRA)" <j...@apache.org>
Subject [jira] [Reopened] (SSHD-401) Allow user control over ScpCommand send/receive buffer size
Date Wed, 11 Feb 2015 11:49:11 GMT

     [ https://issues.apache.org/jira/browse/SSHD-401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Guillaume Nodet reopened SSHD-401:
----------------------------------

Now that I think about it, I wonder if a better way would be to pass customisation parameters
through the FactoryManager.

If a command implements SessionAware, it will receive the session that can be used to retrieve
the FactoryManager and access all custom parameters.

It would seem a bit cleaner to me, thoughts ?

> Allow user control over ScpCommand send/receive buffer size
> -----------------------------------------------------------
>
>                 Key: SSHD-401
>                 URL: https://issues.apache.org/jira/browse/SSHD-401
>             Project: MINA SSHD
>          Issue Type: Improvement
>    Affects Versions: 0.14.0
>            Reporter: Goldstein Lyor
>            Assignee: Guillaume Nodet
>            Priority: Minor
>             Fix For: 0.14.0
>
>         Attachments: SSHD-395-to-401.diff
>
>
> While 8192 is a good rule-of-thumb value for I/O buffering, IMO we should allow users
to fine-tune it to their needs. Attached is a patch suggestion. *Note*: the patch also optimizes
the allocated I/O buffer by taking into consideration the *size* of the file it is expecting
to send/receive



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message