mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Goldstein Lyor (JIRA)" <j...@apache.org>
Subject [jira] [Created] (SSHD-407) Use a Builder in order to create a ScpCommandFactory
Date Tue, 10 Feb 2015 11:35:35 GMT
Goldstein Lyor created SSHD-407:

             Summary: Use a Builder in order to create a ScpCommandFactory
                 Key: SSHD-407
                 URL: https://issues.apache.org/jira/browse/SSHD-407
             Project: MINA SSHD
          Issue Type: Improvement
            Reporter: Goldstein Lyor
            Priority: Minor
             Fix For: 0.14.0

Since the _ScpCommandFactory_ has so many configuration arguments due to SSHD-395 and SSHD-401
(and I have a few more ideas), I thought it would be more appropriate to use a _Builder_ pattern.
Attached is the proposed patch.

A few side-notes:

* I added the _ObjectBuilder_ interface as a standard way to expose _Builder_(s) + modified
the existing ones accordingly
* Added _mockito-all_ test artifacts - very useful for mocking interfaces and interactions
- in my case, it was so I wouldn't have to implement some interfaces since I do not intend
of calling them

This message was sent by Atlassian JIRA

View raw message