mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Gregoire (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DIRMINA-934) Replace synchronized with a Semaphore for better performance
Date Fri, 12 Jun 2015 01:07:00 GMT

    [ https://issues.apache.org/jira/browse/DIRMINA-934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582769#comment-14582769
] 

Paul Gregoire commented on DIRMINA-934:
---------------------------------------

What we have now works well, but I'd love to see the sync stuff go away personally. What did
you guys do in 3.x for decoding, is it the same code? Eventually, I believe that IntStreams
are going to replace a lot of our current routines.

https://docs.oracle.com/javase/8/docs/api/java/util/stream/IntStream.html

> Replace synchronized with a Semaphore for better performance
> ------------------------------------------------------------
>
>                 Key: DIRMINA-934
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-934
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.7, 2.0.8
>         Environment: Window 8 Pro x64, JDK 7
>            Reporter: Paul Gregoire
>              Labels: patch
>             Fix For: 2.0.8
>
>         Attachments: ProtocolCodecFilterWithSemaphoreAndMore.diff
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Replacing the synchronized block with a Semaphore in the ProtocolCodecFilter provides
a lot of benefit in terms of locking and also reduces CPU utilization. See attached git diff.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message