mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sngardner <...@git.apache.org>
Subject [GitHub] mina-sshd pull request: Candidate fix for SSHD-557
Date Thu, 10 Sep 2015 21:27:51 GMT
GitHub user sngardner opened a pull request:

    https://github.com/apache/mina-sshd/pull/12

    Candidate fix for SSHD-557

    Fixes whole-server hang by removing blocking waitForSpace() call and replacing it with
getSize(). In the case that there is no space available, flush() will not block any more and
will simply try again - a zero-length buffer will be passed to waitAndConsume(), but that
method will immediately return.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sngardner/mina-sshd master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/mina-sshd/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12
    
----
commit 1985eb88f64af43dcd17d0e263aa6261f307a9ce
Author: sngardner <sgardner@trustwave.com>
Date:   2015-09-10T21:26:46Z

    Candidate fix for SSHD-557
    
    Fixes whole-server hang by removing blocking waitForSpace() call and replacing it with
getSize(). In the case that there is no space available, flush() will not block any more and
will simply try again - a zero-length buffer will be passed to waitAndConsume(), but that
method will immediately return.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message