mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christoph John <christoph.j...@macd.com>
Subject Re: Errors when buuilding MINA 2.0 branch
Date Sat, 03 Mar 2018 22:10:08 GMT
https://github.com/apache/mina/pull/13



On 03/03/18 22:54, Christoph John wrote:
> BTW, is there a reason why **/Abstract* and **/*RegressionTest* are excluded fromthe
surefire 
> plugin? This leads to some tests not executed, in my case specifically the tests for

> AbstractIoService.
>
> Chris.
>
> On 03/03/18 22:41, Christoph John wrote:
>> Hi,
>>
>> I'll open a PR in due course for the tests for DIRMINA-1076/1077. But I don't thinkthat
the 
>> release needs to wait for this.
>>
>> Thanks and cheers,
>> Chris.
>>
>> On 03/03/18 21:32, Jonathan Valliere wrote:
>>> No, I don’t feel like fixing it.  It really duplicates the efforts of some
>>> other existing unit tests.  Specifically the ones referenced in
>>> DIRMINA-1076/1077
>>>
>>> Please revert one of the AprIoProcessor commits.  Otherwise, I don’t have
>>> anything else.
>>>
>>> On Sat, Mar 3, 2018 at 3:23 PM, Emmanuel Lécharny <elecharny@gmail.com>
>>> wrote:
>>>
>>>>
>>>> Le 03/03/2018 à 21:15, Jonathan Valliere a écrit :
>>>>> Emmanuel,
>>>>>
>>>>> IMHO ConnectorTest, from a quick glance, suffers from some pretty bad
>>>>> concurrency problems in how it waits on the handler and manipulates the
>>>>> buffer independent of whatever the IoProcessor is doing. I would expect
>>>> it
>>>>> to fail randomly.  I don’t think that these failures indicate anything
>>>>> wrong with Mina.
>>>>
>>>> Ok. I'll @Ignore the test then, unless you want to fix it.
>>>>
>>>>
>>>> Is there anything else we want to get fixed before I start cuting 2.0.17
?
>>>>
>>>>
>>>> -- 
>>>> Emmanuel Lecharny
>>>>
>>>> Symas.com
>>>> directory.apache.org
>>>>
>>>>
>>
>

-- 
Christoph John
Development & Support
T +49 241 557080-28
christoph.john@macd.com

MACD GmbH
Oppenhoffallee 103
D-52066 Aachen
www.macd.com

Amtsgericht Aachen: HRB 8151
Ust.-Id: DE 813021663
Geschäftsführer: George Macdonald


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message