mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Lécharny <elecha...@gmail.com>
Subject Fwd: Adding a secured() event in the IoHandler
Date Fri, 13 Apr 2018 16:25:01 GMT
Sent to the dev list, where it belongs...


-------- Message transféré --------
Subject: Re: Adding a secured() event in the IoHandler
To: Emmanuel Lécharny <elecharny@gmail.com>

If nextFilter.fire is called within messageReceived then it will send the
event to SSL Filter + 1; if nextFilter.fire is called within messageSent
then it will send the event to SSL Filter -1;  Forcing it to start at the
head would make it more uniform and allow for debugging filter to be ahead
of the SSL Filter.   Not really a big deal.

On Fri, Apr 13, 2018 at 10:52 AM, Emmanuel Lécharny <elecharny@gmail.com>
wrote:

>
>
> Le 13/04/2018 à 16:32, Jonathan Valliere a écrit :
> > Couple of comments:
> >
> >
> >    1. Any specific reason why you chose “fire” for the base name of the
> >    handler function instead of something like “event” ?
>
> No. It could be named event if it makes more sense.
>
>
> >    2. Instead of calling nextFilter.fire; you might want to call
> >    session.getFilterChain().fire() or
> >    session.getFilterChain().getEntry(this).fire() force correct downward
> >    behavior regardless of current processing direction.
>
> I don't think it makes any sense to propagate an event back to the head.
> The only place processing events is the IoHandler, which is the next
> after the tail.
>
> --
> Emmanuel Lecharny
>
> Symas.com
> directory.apache.org
>
>


Mime
View raw message